-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge dev to main #596
Merged
Merged
Merge dev to main #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ianpittwood
commented
Jul 28, 2023
- Workflow refactor
- Disable concurrent runs by ref
- Disable caching for image builds due to instability
- Fix License Manager on Workbench for Azure ML and fix Goss tests post-jammy upgrade
- Update CODEOWNERS file
- Update GPG keys
- Release Connect 2023.07.0
* Unify R and Python versions * Add `get-base-tags` and `get-base-args` just targets * Change build-preview-webhook.yaml default to "ubuntu2204" * Begin prototyping generic build/test/scan/push workflow * Switch to composite action * Specify shell to bash * Use CSV list for tags * Use printf to get line sep build args * Add build-args input option * Print and pass build args as block * Fix build args list for tests and fix first tag cut * Fix tagging OS variable * Pass OS to test command * Use .env file for tests * Add `update-quarto-versions` target - Update all Quarto to 1.3.340 - Pass Quarto down as build arg * Restrict centos7 to older versions of R and Python Add base-pro build * Trim driver suffix for centos pro builds * Add product builds to pipeline * Add build-prerelease.yaml replacing build-preview.yaml Cleanup CI naming and Justfile * Check that $BRANCH is not empty * Update context path for preview builds * Push base images on dev Update context for prerelease * Fix RSW download url for prerelease * Add PYTHON_VERSION_JUPYTER to ci args * Unify `PYTHON_VERSION_JUPYTER` naming convention * Write Python versions to rstudio-connect.gcfg on build * Default push-image to false Modify logic eval on prerelease push * Remove push on base * Remove any reliance on `if` evaluations * Add manual build workflow * Use build-test-scan-push action for content builds * Trim newlines in image tags Disable testing for content * Revert sweeping release image upgrades * Write R version to `rstudio-pm.gcfg` on build * Fix blindspots in Justfile update-versions Update all versions after changes * Update NEWS.md docs * Always order tags from most specific to most generic * Update Workbench for Azure ML Python versions * Free up additional space in action.yaml * Retry builds once on failure * Update OS in just target doc Co-authored-by: Benjamin R. J. Schwedler <[email protected]> * Update ci.Justfile target docs * Extract content tags and args creation to ci.Justfile * Note that we can't use "if:" in our action --------- Co-authored-by: Benjamin R. J. Schwedler <[email protected]>
* Disable concurrent runs by ref Cancels previous runs for each build workflow by ref to ensure only one runs at a time * Add more specificity to concurrency group name * Remove duplicated content build
* Begin prototyping generic build/test/scan/push workflow * Switch to composite action * Debug echo build args in action * Feed build args as JSON to action * Print and pass build args as block * Debug build-args pass and fix outputs var * Add `update-quarto-versions` target - Update all Quarto to 1.3.340 - Pass Quarto down as build arg * Default push-image to false Modify logic eval on prerelease push * Debug image pushes * Remove debugging statements * Write R version to `rstudio-pm.gcfg` on build * Fix permissions on rstudio-pm.gcfg * Revert changes for dynamic rstudio-pm.gcfg * Use secrets directly from action.yaml * Revert "Use secrets directly from action.yaml" This reverts commit 4dace23. * Change license-manager COPY step to after LM replacement Update Goss libssl1.0.0 sys package variable to libssl-dev for Ubuntu 22.04 * Remove R 3.5.3 (archived) and add R 4.3.1 * Add `openssh-client` to Dockerfile sys dependencies * Rebase and cleanup * Reduce file permissions for license-manager.conf
Also update package-manager to use the new team name: ppm
Update CODEOWNERS to include platform team members
Without including the scheme in the URL for the GPG keyserver we would see an error on Centos 7. Adding hkps:// to the URL gets around this issue for the new key. Also added rpm import of the older key.
Add post 07/25/23 gpg key
* Update Justfile RSC_VERSION to 2023.07.0 * Update connect/Justfile RSC_VERSION to 2023.07.0 * connect release 2023.07.0 --------- Co-authored-by: Ian Pittwood <[email protected]> Co-authored-by: Benjamin R. J. Schwedler <[email protected]>
ianpittwood
requested review from
cm421,
melissa-barca,
a team,
colearendt and
atheriel
as code owners
July 28, 2023 13:54
bschwedler
approved these changes
Jul 28, 2023
* Symlink to the default Python and R versions * Switch around symlinking order
Update preview and latest builds for generic PPM installers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.