Fixes for failing CRAN checks #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would require taking a dependancy on {curl}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, CRAN checks for reticulate started failing on macOS-oldrel.
After some investigation, it appears that the macOS-oldrel runners—and only the macOS-oldrel runners—set the environment variable
_R_CHECK_VIGNETTES_SKIP_RUN_MAYBE_=falsewhen running checks.My understanding is that this results in the vignettes being processed with
knitr::purl(), which converts them into a script. The script is then evaluated as part of the checks. In the context where the script is evaluated,knitrcalls likeknitr::opts_chunk$set(eval = FALSE)do not function, and chunks that are not meant to be evaluated in vignettes still get evaluated, leading to errors, and CRAN check failures.This is affecting downstream packages and is also the reason why CRAN machines have not built a binary for the latest release of reticulate.
This issue is also impacting other packages:
RcppCore/RcppArmadillo#447
yihui/knitr#2338