Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(serializer): Add support for ragg and svglite #964

Merged
merged 6 commits into from
Nov 14, 2024

Conversation

thomasp85
Copy link
Contributor

I have not added a bullet to NEWS since it does not have an entry for the dev version yet and I did not want to create it in this PR (happy to do so if requested)

@CLAassistant
Copy link

CLAassistant commented Nov 12, 2024

CLA assistant check
All committers have signed the CLA.

@schloerke
Copy link
Collaborator

@thomasp85 Can you please set up the dev version / news entry area? (Along with a news entry for your PR). Thank you!

@schloerke
Copy link
Collaborator

@thomasp85 #965 added a news entry / dev version and fixed the pkgdown error. Please add a news item and I'll merge. Thank you!

@schloerke schloerke changed the title add support for ragg and svglite feat(serializer): Add support for ragg and svglite Nov 12, 2024
@schloerke
Copy link
Collaborator

Forgot during initial review. Please add an entry in

Annotation | Content Type | Description/References
---------- | ------------ | ---------------------
`@serializer contentType` | (user supplied) | Send response with a particular `Content-Type` header
`@serializer html` | `text/html; charset=UTF-8` | Passes response through without any additional serialization
`@serializer json` | `application/json` | Object processed with `jsonlite::toJSON()`
`@serializer unboxedJSON` | `application/json` | Object processed with `jsonlite::toJSON(auto_unbox=TRUE)`
`@serializer rds` | `application/rds` | Object processed with `base::serialize()`
`@serializer csv` | `text/csv` | Object processed with `readr::format_csv()`
`@serializer tsv` | `text/tab-separated-values` | Object processed with `readr::format_tsv()`
`@serializer feather` | `application/vnd.apache.arrow.file` | Object processed with `arrow::write_feather()`
`@serializer parquet` | `application/parquet` | Object processed with `arrow::write_parquet()`
`@serializer yaml` | `text/x-yaml` | Object processed with `yaml::as_yaml()`
`@serializer htmlwidget` | `text/html; charset=utf-8` | `htmlwidgets::saveWidget()`
`@serializer text` | `text/plain` | Text output processed by `as.character()`
`@serializer format` | `text/plain` | Text output processed by `format()`
`@serializer print` | `text/plain` | Text output captured from `print()`
`@serializer cat` | `text/plain` | Text output captured from `cat()`
`@serializer jpeg` | `image/jpeg` | Images created with `jpeg()`
`@serializer png` | `image/png` | Images created with `png()`
`@serializer svg` | `image/svg` | Images created with `svg()`
`@serializer bmp` | `image/bmp` | Images created with `bmp()`
`@serializer tiff` | `image/tiff` | Images created with `tiff()`
`@serializer pdf` | `application/pdf` | PDF File created with `pdf()`

Thank you!


  • News Entry
  • Vignette: Serializer table entry

@thomasp85
Copy link
Contributor Author

Thanks for the review - should all be fixed now

@schloerke schloerke merged commit c9d18e3 into rstudio:main Nov 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants