Allows port to be specified as an environment variable #963
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #956 (tagged 'help wanted').
The error returned there is an Rcpp error, as the httpuv function that's ultimately called is expecting an integer input and can't handle the implicit character -> integer conversion. Environment variables are by default retrieved as strings.
I've added the
as.integer()
conversion as a catch-all, rather than add a conditional branch as:i) I find it slightly more readable
ii) slightly more defensive, in case the methods to find a random port above it are updated
iii)
getRandomPort()
returns a double so there would have been an implicit conversion at the Rcpp level anywayIncludes a regression test.
PR task list:
devtools::document()