fix: align resolve.extensions with webpack builder
#80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenjiahan
reviewed
Sep 3, 2024
| @@ -288,6 +288,15 @@ export default async ( | |||
|
|
|||
| config.resolve ??= {} | |||
| config.resolve.symlinks = !isPreservingSymlinks() | |||
| config.resolve.extensions = [ | |||
There was a problem hiding this comment.
How about change the default value in Rsbuild?
There was a problem hiding this comment.
I've considered this option. And I think Storybook has some exclusive convention and may affect the whole Storybook ecosystem. It's better to perfect consistency with Storybook's config to avoid other breaks in the future. Rsbuild's default value could handle most practices, but Storybook is a bit special. :P
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #76.