fix: make rsbuild listen on a random port

[tmkx]

close #23
close #32

[fi3ework]

Great work! I am wondering should Rsbuild listen to a port in middleware mode? If so, what's the purpose? 🤔 Could @chenjiahan give some guidance.

[chenjiahan]

Rsbuild server should not listen to any port in the middleware mode, @9aoy can you check this

[fi3ework]

I'm merging the PR now, we could improve the default behavior in Rsbuild after @9aoy checks the code. Thanks @tmkx!

[9aoy]

This problem is caused by configuring strictPort: true. Rsbuild will parse the configuration (including calculating available port) when the server is initialized. When the port is occupied and strictPort is configured, an error will be reported.

https://github.com/web-infra-dev/rsbuild/blob/v0.7.9/packages/core/src/server/helper.ts#L219-L224

[fi3ework]

Got it, I'll remove port setting.

[matheusmichels]

Hey @fi3ework, this fixed the "occupied port" issue when running Storybook from a container/remote environment. However, the HMR stopped working cause now Storybook doesn't know the dev server port.

[tmkx]

rsbuild will listen to another port due to a port conflict, but hmr still works because the rsbuild dev middleware can accept connections through the Storybook server

storybook-rsbuild/packages/builder-rsbuild/src/index.ts

Line 135 in 1c539b3

router.use(rsbuildServer.middlewares)

for a speedy verification, you can follow the instructions to confirm if it functions in a container environment:

FROM ubuntu:latest

ENV COREPACK_ENABLE_DOWNLOAD_PROMPT=0
ENV NVM_DIR=/root/.nvm

ADD https://github.com/rspack-contrib/storybook-rsbuild.git /app

WORKDIR /app

RUN apt-get update && apt-get install -y curl && \
  curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.7/install.sh | bash && \
  . ~/.bashrc && nvm install && \
  corepack enable && pnpm i && pnpm build

EXPOSE 6006
CMD [ "bash", "-c", ". /root/.nvm/nvm.sh && pnpm -C sandboxes/react-18 exec storybook dev --no-open -p 6006" ]