fix(react-rsbuild): avoid race condition in async #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While in the previous code,
const tsconfigPath = await findUp('tsconfig.json', { cwd: process.cwd() })
introduced aysnc logic so thetsconfigPathsInitialized
will not take effect when multiplereactDocgenLoader
invoked at the same time and will result in repeated initialization for many times.this PR fixed that to work with the async logic.
Conceptually, this should also raise with
@storybook/builder-webpack5
but I can't reproduce it with a demo. The async logic will always be finished before other invoking. I will launch another a PR to@storybookjs/storybook
since the code here is copied from the repository (https://github.com/storybookjs/storybook/blob/next/code/presets/react-webpack/src/loaders/react-docgen-loader.ts).cc @chenjiahan