Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should compile virtual module #25

Merged
merged 1 commit into from
Jun 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/builder-rsbuild/src/preview/iframe-rsbuild.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,9 @@ export default async (
progressBar: !quiet,
},
source: {
// TODO: Rspack doesn't support virtual modules yet, use cache dir instead
// we needed to explicitly set the module in `node_modules` to be compiled
include: [/[\\/]node_modules[\\/].*[\\/]storybook-config-entry\.js/],
alias: {
...storybookPaths,
},
Expand Down
1 change: 1 addition & 0 deletions sandboxes/react-rsbuild/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"private": true,
"description": "",
"author": "",
"type": "module",
"scripts": {
"build": "rsbuild build",
"build:storybook": "storybook build",
Expand Down