Make settle release request more robust #2923
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorder rskip
Add tests Refactor Rename variable
Add key to storage index Remove declaration of svp fund tx hash since it is not being used yet. Remove _KEY suffix
Remove _KEY suffix. Save proposed federation the same way as pending one
Add proposedFederationIsSet logic Getting rid of proposedFederationIsSet logic. Add isProposedFederationSet logic. Add rskip419 check in saveProposedFederation method Save null version when proposed federation is null Remove unnecessary private method Refactor Removes null activations from tests
Make variable final Improve test name Use all activations instead of lovell Improve null handling
Add get proposed federation tests Minor fix after rebase Improve comment Minor refactor Minor refactor Improve comment Add test case Throw exception when there is no storage version for non-null proposed federation Add test cases Add log. Add test case and refactor Remove unused import
…sh methods and tests Rebases Reorders and renames tests Rebases Appends SVP prefix to FUND_TX_HASH_UNSIGNED and refactors tests Rebases Moves repeated arrange code to setup. Using Optional. Rebases Removes _ from the key Using arrowhead631 Rebases Rebases Renames saveFundTransactionUnsignedHash to saveSvpFundTransactionUnsignedHash Renames FundTransactionUnsignedHash instance fields
Remove unnecessary private method Refactor
Add get proposed federation tests Minor fix after rebase Improve comment Minor refactor Add test case
…d federation Add test cases Add log. Add test case and refactor Remove unused import
…sh methods and tests Rebases Moves repeated arrange code to setup. Using Optional. Rebases
Adds test to assert empty is returned when hash hasn't been set or saved Renames svp fields to match the RSKIP419 description. Adds more tests. Using standard. Renames test
Improve variable name Add comment Minor refactors Improve comments. Minor refactors Improve comments Refactor Add tests for commitFederationAccordingToActivations Remove unnecessary semicolon Refactor to improve testing and readability Add test cases Remove some tests. Make bridge event logger not a mock. Make some methods private instead of protected. Fix log message Improve test name Change test name Move reused method to utility class. Use real block instead of a mock Make methods to be private instead of protected
Add method to utils
Fix sonar complains Add missing import Move method to test class Remove unused imports
…y to bridge storage index key
… to bridge storage provider Remove svp fund tx tests from federation storage provider tests, and adds them to bridge storage provider tests Get rid of sonar complains Add get methods to bridge Put save, set and get tests in same nested class
Add tests. Add missing tests for minimum pegout tx value Modify test
… creating pegouts
Refactor and add test case Add test case Remove mistaken comment Add comment Modify comment
Huge refactor to get rid of duplicated code Minor refactor Minor refactors Renaming, refactors. Add missing test case. Minor fix Reorder, refactor Fix typo, refactor Rename Create private method to get rid of duplicated code Get rid of sonar complains Rename already declared federator keys field. Rename variables to match regular expressions
julia-zack
force-pushed
the
make_settleReleaseRequest_more_robust
branch
from
d421692 to
9fcb0fa
Compare
julia-zack
force-pushed
the
refactor_svp_tests
branch
from
66d58f9 to
f821e19
Compare
julia-zack
force-pushed
the
make_settleReleaseRequest_more_robust
branch
from
f883092 to
44b47b5
Compare
Rollback change in fund tx value
julia-zack
force-pushed
the
refactor_svp_tests
branch
from
f821e19 to
c0de479
Compare
Remove assert methods that do not return void
Base automatically changed from
refactor_svp_tests
to
feature/powpeg_validation_protocol-phase4
January 10, 2025 14:32
julia-zack
force-pushed
the
make_settleReleaseRequest_more_robust
branch
from
44b47b5 to
c4cfe2d
Compare
…ocol-phase4 Feature/powpeg validation protocol phase4
Base automatically changed from
feature/powpeg_validation_protocol-phase4
to
feature/powpeg_validation_protocol-integration
January 10, 2025 18:51
…alizing_rskTxs Return null early in public method instead of in private one.
julia-zack
force-pushed
the
make_settleReleaseRequest_more_robust
branch
from
919e01b to
cfffcbb
Compare
julia-zack
force-pushed
the
make_settleReleaseRequest_more_robust
branch
from
cfffcbb to
8f7889f
Compare
|
marcos-iov
force-pushed
the
feature/powpeg_validation_protocol-integration
branch
from
09ff25b to
2545809
Compare
Base automatically changed from
feature/powpeg_validation_protocol-integration
to
master
January 24, 2025 18:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The available UTXOs and the requested amount in a request were being passing around some methods.
To avoid this, three different methods were created to settle the release of: pegout, migration, svp fund tx, since both utxos and requested amount are different for each release type.