Adding min and max ranges to check the value provided by the Oracle's #2922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
fmacleal
requested changes
Jan 17, 2025
rskj-core/src/main/java/co/rsk/config/mining/StableMinGasPriceSystemConfig.java
Outdated
Show resolved
Hide resolved
rskj-core/src/main/java/co/rsk/mine/gas/provider/StableMinGasPriceProvider.java
Outdated
Show resolved
Hide resolved
|
fmacleal
approved these changes
Jan 22, 2025
rmoreliovlabs
approved these changes
Jan 23, 2025
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a configurable valid range (minValidPrice and maxValidPrice) for the BTC price retrieved from the oracle. The system will validate the price against this range before updating it. If the price is outside the range, it will not be updated, and a warning will be logged.
Motivation and Context
The motivation behind this change is to improve the robustness of the system by preventing updates with incorrect or extreme BTC prices. By enforcing a valid range, we can ensure that only reliable and expected values are used, minimizing potential risks and maintaining system integrity.
How Has This Been Tested?
Types of changes
Checklist: