Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert reason delegation #1561

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Revert reason delegation #1561

wants to merge 2 commits into from

Conversation

fedejinich
Copy link
Contributor

@fedejinich fedejinich commented Jun 15, 2021

Description

All the EthModule public methods are eth_ calls, except for EthModule.decodeRevertReaseon(), which only uses the program result to decode the revert reason.

I'm taking out that responsibility from EthModule and delegate to ProgramResult, to use it whenever we want to decode a revert reason

Motivation and Context

Fixes this #1560 .
Easy to solve tech debt.

How Has This Been Tested?

I'll add some tests for programResult.decodeRevertReason

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant