Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All the
EthModule
public methods areeth_
calls, except forEthModule.decodeRevertReaseon()
, which only uses the program result to decode the revert reason.I'm taking out that responsibility from
EthModule
and delegate toProgramResult
, to use it whenever we want to decode a revert reasonMotivation and Context
Fixes this #1560 .
Easy to solve tech debt.
How Has This Been Tested?
I'll add some tests for programResult.decodeRevertReason
Types of changes
Checklist: