Sets uninitialized socket file descriptors to -1 #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amendelzon
previously approved these changes
Jan 10, 2025
Sets the value of uninitialized file descriptors on io.c to -1 instead of 0.
italo-sampaio
force-pushed
the
enhancement/241-fix-uninitialized-socket-fd
branch
from
3937a2b to
efe80b5
Compare
Returning -1 instead of 0 from start_server function
italo-sampaio
force-pushed
the
enhancement/241-fix-uninitialized-socket-fd
branch
from
efe80b5 to
355ff20
Compare
VaWheel
approved these changes
Jan 17, 2025
amendelzon
added a commit
that referenced
this pull request
Jan 21, 2025
* Fixes coverage report for feature/sgx branch (#224) - Triggers the coverage workflow for pushes to master and feature/sgx branches - Adds optional exec argument unit tests scripts - Some additional fixes to unit tests * Install SGX powHSM as a systemd service (#226) * Version 5.3.2 ALPHA release (#227) - Bumped version to 5.3.2 - Updated version references in firmware, middleware and unit tests - Updated CHANGELOG * Fix middleware docker image build (#252) * Fixed C linting to include sgx code (#261) - Including sgx code in lint-c/format-c scripts - Fixed reported sgx linting errors * Sets uninitialized socket file descriptors to -1 (#248) Sets the value of uninitialized file descriptors on io.c to -1 instead of 0. * Removes .gitignore from distribution builds (#264) * Fixes signature for finalise function (#249) Fixes the signature of finalise function so that it conforms with the expected signal handler function signature * Fixes formatting error identified by C linter (#266) * Sanitizes key for kvstore (#247) - Sanitizes the key before using it for file operations. - Added unit tests for keyvalue_store module * Added APDU buffer pointer validation to SGX enclave init sequence (#267) - Using oe_is_outside_enclave to validate the APDU buffer in system_init - Added and updated unit tests cases * Moves finalise logic out of signal handler (#268) Signal handler now only sets a flag that is checked in main * Fixed C linting errors --------- Co-authored-by: Italo Sampaio <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the value of uninitialized file descriptors on io.c to -1 instead of 0.