Compare balances using base units #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanieliov
previously approved these changes
Apr 4, 2024
| expect(federationAddressBalanceAfterPegin).to.be.equal(Number(federationAddressBalanceInitial + minimumPeginValueInBtc)); | ||
| const federationAddressBalanceInBtcAfterPegin = Number(await btcTxHelper.getAddressBalance(federationAddress)); | ||
| const federationAddressBalanceInSatoshisAfterPegin = Number(btcEthUnitConverter.btcToSatoshis(federationAddressBalanceInBtcAfterPegin)); | ||
| expect(federationAddressBalanceInSatoshisAfterPegin).to.be.equal(Number(federationAddressBalanceInSatoshisInitial + minimumPeginValueInSatoshis)); |
There was a problem hiding this comment.
Suggested change
| expect(federationAddressBalanceInSatoshisAfterPegin).to.be.equal(Number(federationAddressBalanceInSatoshisInitial + minimumPeginValueInSatoshis)); | |
| const expectedBalanceAfterPegin = Number(federationAddressBalanceInSatoshisInitial + minimumPeginValueInSatoshis); | |
| expect(federationAddressBalanceInSatoshisAfterPegin).to.be.equal(expectedBalanceAfterPegin); |
|
pipeline:run |
1 similar comment
|
pipeline:run |
marcos-iov
dismissed stale reviews from nathanieliov and jeremy-then
via
60b85c7
marcos-iov
force-pushed
the
comparision-units
branch
3 times, most recently
from
a5ba1f5 to
7a5b086
Compare
marcos-iov
force-pushed
the
comparision-units
branch
from
7a5b086 to
7ad1f25
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.