Fixes waitForBlock logic to not stop searching if the blockchain is a… #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcos-iov
approved these changes
Jan 11, 2024
nathanieliov
approved these changes
Jan 11, 2024
|
Rebase and then merge it |
…t least advancing
jeremy-then
force-pushed
the
fix-waitForBlock-bug
branch
from
35405c1 to
da7b572
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes waitForBlock logic to not stop searching if the blockchain is at least advancing. Unless it gets stuck in a block and the
maxAttemptsgets consumed waiting for the blockchain to advance.