Debug failures #23
Merged
Debug failures #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pipeline:run |
8 similar comments
|
pipeline:run |
|
pipeline:run |
|
pipeline:run |
|
pipeline:run |
|
pipeline:run |
|
pipeline:run |
|
pipeline:run |
|
pipeline:run |
|
pipelinee:run |
|
pipeline:run |
jeremy-then
force-pushed
the
debug-failures
branch
from
8c81c59 to
e286330
Compare
|
pipeline:run |
…re each test execution
jeremy-then
force-pushed
the
debug-failures
branch
from
f1b725d to
98af287
Compare
marcos-iov
previously approved these changes
Dec 12, 2023
marcos-iov
force-pushed
the
debug-failures
branch
from
98af287 to
87a2d38
Compare
|
marcos-iov
approved these changes
Dec 12, 2023
nathanieliov
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes on this PR fix the issues we have had recently with executions failing more than normal.
It turns out that sometimes when we send a transaction to the rsk or bitcoin network, the transaction can take a bit longer to reach those blockchain's mempool. Before, we were simply mining a block right after sending the transaction, thinking that it was immediately ready to be mined, but some times it is not and we didn't mine it, hence, some assertions fail.
Now, the new logic on this pr simply waits for new transactions or a specific transaction to get to the bitcoin and rsk mempool before mining.
The idea is that after sending any transaction to the bitcoin and rsk networks, before proceeding to mine and continue, we should allow enough time for the tx to get to the mempool first. This doesn't happen all the time, and usually depends on the resources that the computer running these tests have, since there are many services running independently at once while running the tests.
The
waitAndUpdateBridgefunction was moved from the2wp.utils.jsfile to thersk-utils.jsfile to avoid circular dependency since it is now required in thersk-utils.jsfile and the2wp.utils.jsis already importing thersk-utils.jsmodule.The
retryWithCheckfunction was refactored to return an option with the result and the current attempts where it found (or not) the result. This can be useful for debugging.This pr includes the changes of the pr #20. So, once this is merged, we can close the other.