Adds 'should reject and refund a pegout with value exactly below mini… #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apancorb
approved these changes
Oct 22, 2024
lib/tests/2wp.js
Outdated
|
|
||
| // Arrange | ||
|
|
||
| // Create a pegin for the serder to ensure there is enough funds to pegout and because this is the natural process |
There was a problem hiding this comment.
Suggested change
| // Create a pegin for the serder to ensure there is enough funds to pegout and because this is the natural process | |
| // Create a pegin for the sender to ensure there is enough funds to pegout and because this is the natural process |
| @@ -56,6 +56,12 @@ const PEGIN_UNREFUNDABLE_REASONS = { | |||
| INVALID_AMOUNT: '3', | |||
| }; | |||
|
|
|||
| const PEGOUT_REJECTION_REASONS = { | |||
There was a problem hiding this comment.
Just for my understanding, these are the codes found in rskj right?
There was a problem hiding this comment.
jeremy-then
force-pushed
the
add-should-reject-and-refund-pegout-below-minimum-test
branch
from
a26846a to
71b037b
Compare
nathanieliov
approved these changes
Oct 23, 2024
jeremy-then
force-pushed
the
rits-refactors-9-2024-integration
branch
from
d2040bb to
70af72b
Compare
jeremy-then
force-pushed
the
add-should-reject-and-refund-pegout-below-minimum-test
branch
from
36834c7 to
c792c63
Compare
jeremy-then
force-pushed
the
rits-refactors-9-2024-integration
branch
from
70af72b to
a1fcb8d
Compare
marcos-iov
reviewed
Oct 29, 2024
lib/tests/2wp.js
Outdated
|
|
||
| // Create a pegin for the sender to ensure there is enough funds to pegout and because this is the natural process | ||
| const senderRecipientInfo = await createSenderRecipientInfo(rskTxHelper, btcTxHelper); | ||
| const peginValueInSatoshis = btcToSatoshis(0.5); |
There was a problem hiding this comment.
Maybe this value could be in function of what we are trying to do?
MIN_PEGOUT_VALUE * 2 for example?
Or maybe have a constant defined, BRIDGE_FUNDING_VALUE or something of the sort.
What do you think?
lib/tests/2wp.js
Outdated
| const initialBtcRecipientAddressBalanceInSatoshis = await getBtcAddressBalanceInSatoshis(btcTxHelper, senderRecipientInfo.btcSenderAddressInfo.address); | ||
| const initialRskSenderBalanceInWeisBN = await rskTxHelper.getBalance(senderRecipientInfo.rskRecipientRskAddressInfo.address); | ||
| // Value exactly below minimum | ||
| const pegoutValueInRbtc = parseFloat((MINIMUM_PEGOUT_AMOUNT_IN_RBTC - 0.0001).toFixed(8)); |
There was a problem hiding this comment.
I feel like this could be a lot easier if we stored the min pegout value in satoshis or weis. Less parsing and decimal handling
|
|
||
| // The rsk sender balance is the same as the initial balance minus the gas fee, because the pegout amount was refunded. | ||
| const finalRskSenderBalanceInWeisBN = await rskTxHelper.getBalance(senderRecipientInfo.rskRecipientRskAddressInfo.address); | ||
| const gasFee = pegoutTransaction.gasUsed * pegoutTransaction.effectiveGasPrice; |
There was a problem hiding this comment.
Super nice, well done!
Rebasing
…mum' test Rebase.
jeremy-then
force-pushed
the
add-should-reject-and-refund-pegout-below-minimum-test
branch
from
c792c63 to
c8d5e3e
Compare
|
marcos-iov
approved these changes
Oct 30, 2024
marcos-iov
merged commit 8845a44
into
rits-refactors-9-2024-integration
2 of 3 checks passed
marcos-iov
deleted the
add-should-reject-and-refund-pegout-below-minimum-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 'should reject and refund a pegout with value exactly below minimum' test