disable whitelisting #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcos-iov
reviewed
Sep 27, 2023
marcos-iov
force-pushed
the
disable-whitelist
branch
from
544c78a to
968ecf2
Compare
marcos-iov
reviewed
Sep 27, 2023
jeremy-then
reviewed
Sep 27, 2023
lib/2wp-utils.js
Outdated
| const latestActiveForkName = await getLatestActiveForkName(); | ||
| const bridge = getBridge(rskTxHelper.getClient(), latestActiveForkName); | ||
|
|
||
| const addr = await rskTxHelper.importAccount(WHITELIST_CHANGE_PK) |
There was a problem hiding this comment.
Suggested change
| const addr = await rskTxHelper.importAccount(WHITELIST_CHANGE_PK) | |
| const whitelistChangeAddress = await rskTxHelper.importAccount(WHITELIST_CHANGE_PK) |
jeremy-then
reviewed
Sep 27, 2023
lib/2wp-utils.js
Outdated
| @@ -15,6 +15,8 @@ const ADDRESS_TYPES_CODES = { | |||
| const BTC_TO_RSK_MINIMUM_CONFIRMATIONS = 3; | |||
| const TO_BRIDGE_GAS_PRICE = 2; | |||
| const BRIDGE_ADDRESS = '0x0000000000000000000000000000000001000006'; | |||
| const WHITELIST_CHANGE_PK = '3890187a3071327cee08467ba1b44ed4c13adb2da0d5ffcc0563c371fa88259c'; | |||
| const WHITELIST_CHANGE_ADDR = '87d2a0f33744929da08b65fd62b627ea52b25f8e'; | |||
There was a problem hiding this comment.
These constants are already exported from the whitelisting.js file. Please, import them and use them here. No need to duplicate them.
Also check that they are redeclared again in 01_03_51-2wp_release_event.js and 01_03_52-disable_lock_whitelist.js. Delete them from there and import them on those files from whitelisting.js.
There was a problem hiding this comment.
Should the method in it's entirety be moved to whitelisting.js? Or should it stay here? What do you think?
jpikora-iov
force-pushed
the
disable-whitelist
branch
from
968ecf2 to
2f25bd4
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
marcos-iov
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.