Feature/GBI-1652 - Null script size verification #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MaximStanciu8
approved these changes
Feb 16, 2024
MaximStanciu8
pushed a commit
that referenced
this pull request
Feb 20, 2024
MaximStanciu8
added a commit
that referenced
this pull request
Feb 20, 2024
* Deployed to mainnet * Testnet Deploy * Added dao fee collector address * Fixed comments * Upgraded LBC to testnet * fix update script * LBC upgrade * fix test broken when adding productFeeAmount * enforce test to run on each environment branch * fix time dependant test to run in pipeline * Migrate to BtcUtils published library * fix unsafe integer calculation in test * update to avoid tx to the fee collector if productFee is 0 * contract size optimizations * separate gasFee from callFee * update integration tests * remove addresses from regtest config * testnet upgrade information * ci: add npm config * fix: install lib from new registry * fix: add linebreak in .npmrc * feat: update BtcUtils library * testnet upgrade * 1.1.1 * Qa test (#212) * Feature/GBI-1652 - Null script size verification (#208) * chore: change method of setting github token in workflow * feat: add null script content validation * test: add test to null script content validation * 1.1.2 * Stable test (#211) (#213) * Added dao fee collector address * Fixed comments * Upgraded LBC to testnet * fix update script * fix test broken when adding productFeeAmount * enforce test to run on each environment branch * fix time dependant test to run in pipeline * Migrate to BtcUtils published library * fix unsafe integer calculation in test * update to avoid tx to the fee collector if productFee is 0 * contract size optimizations * separate gasFee from callFee * update integration tests * remove addresses from regtest config * testnet upgrade information * ci: add npm config * fix: install lib from new registry * fix: add linebreak in .npmrc * feat: update BtcUtils library --------- Co-authored-by: MaximStanciu8 <[email protected]> Co-authored-by: Guilherme Soares <[email protected]> --------- Co-authored-by: Guilherme Soares <[email protected]> Co-authored-by: MaximStanciu8 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Check the 1st byte of the null data script to see if size its correct
Why
Improvement suggested by security team
Task
https://rsklabs.atlassian.net/browse/GBI-1652