Skip to content

Commit

Permalink
minor update to text and add info callout
Browse files Browse the repository at this point in the history
  • Loading branch information
owans committed Jan 7, 2025
1 parent 49fd33b commit f941284
Show file tree
Hide file tree
Showing 3 changed files with 39 additions and 3 deletions.
14 changes: 13 additions & 1 deletion docs/02-developers/03-blockchain-essentials/02-overview/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,19 @@ Note that when `eth_estimateGas` is called, the node simulates the transaction e
The simulation runs through the entire transaction process as if it were being executed, including checking for sufficient balance, contract code execution, etc.
During the simulation, the method calculates the exact amount of gas that would be consumed by the transaction if it were to be executed on the blockchain. The estimated gas amount is returned, helping users set an appropriate gas limit for the actual transaction.

Until `Arrowhead 6.5.0`, there was a difference in Rootstock compared to Ethereum, and it is that if one of the steps of the simulated transaction fails, the node would return the gas estimation needed for the transaction, while on Ethereum, the node would return an error instead of the gas estimation. Starting with `Arrowhead 6.5.0` this is not valid anymore, Rootstock will behave same way as Ethereum, returning an error if one of the steps of the simulated transaction fails.
:::info[Info]

**Prior to Arrowhead 6.5.0**, there was a difference in Rootstock compared to Ethereum:

- If one of the steps of the simulated transaction fails, the node would return the gas estimation needed for the transaction
- On Ethereum, the node would return an error instead of the gas estimation.

**Starting with Arrowhead 6.5.0:**

- Rootstock will behave same way as Ethereum's behavior for simulated transaction failures.
- If a simulated transaction step fails, the node will now return an error, mirroring Ethereum's response.

:::

You can see this behavior in the following example, where a call for `eth_estimateGas` on a transaction that would be executed from an address without enough balance.

Expand Down
14 changes: 13 additions & 1 deletion docs/02-developers/07-rpc-api/02-rootstock/02-methods.md
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,19 @@ Note that when `eth_estimateGas` is called, the node simulates the transaction e
The simulation runs through the entire transaction process as if it were being executed, including checking for sufficient balance, contract code execution, etc.
During the simulation, the method calculates the exact amount of gas that would be consumed by the transaction if it were to be executed on the blockchain. The estimated gas amount is returned, helping users set an appropriate gas limit for the actual transaction.

Until `Arrowhead 6.5.0`, there was a difference in Rootstock compared to Ethereum, and it is that if one of the steps of the simulated transaction fails, the node would return the gas estimation needed for the transaction, while on Ethereum, the node would return an error instead of the gas estimation. Starting with `Arrowhead 6.5.0` this is not valid anymore, Rootstock will behave same way as Ethereum, returning an error if one of the steps of the simulated transaction fails.
:::info[Info]

**Prior to Arrowhead 6.5.0**, there was a difference in Rootstock compared to Ethereum:

- If one of the steps of the simulated transaction fails, the node would return the gas estimation needed for the transaction
- On Ethereum, the node would return an error instead of the gas estimation.

**Starting with Arrowhead 6.5.0:**

- Rootstock will behave same way as Ethereum's behavior for simulated transaction failures.
- If a simulated transaction step fails, the node will now return an error, mirroring Ethereum's response.

:::

You can see this behavior on the following example, where we call `eth_estimateGas` for a transaction that would be executed from an address without enough balance.

Expand Down
14 changes: 13 additions & 1 deletion docs/03-node-operators/03-json-rpc/01-methods.md
Original file line number Diff line number Diff line change
Expand Up @@ -1089,7 +1089,19 @@ Note that when `eth_estimateGas` is called, the node simulates the transaction e
The simulation runs through the entire transaction process as if it were being executed, including checking for sufficient balance, contract code execution, etc.
During the simulation, the method calculates the exact amount of gas that would be consumed by the transaction if it were to be executed on the blockchain. The estimated gas amount is returned, helping users set an appropriate gas limit for the actual transaction.

Until `Arrowhead 6.5.0`, there was a difference in Rootstock compared to Ethereum, and it is that if one of the steps of the simulated transaction fails, the node would return the gas estimation needed for the transaction, while on Ethereum, the node would return an error instead of the gas estimation. Starting with `Arrowhead 6.5.0` this is not valid anymore, Rootstock will behave same way as Ethereum, returning an error if one of the steps of the simulated transaction fails.
:::info[Info]

**Prior to Arrowhead 6.5.0**, there was a difference in Rootstock compared to Ethereum:

- If one of the steps of the simulated transaction fails, the node would return the gas estimation needed for the transaction
- On Ethereum, the node would return an error instead of the gas estimation.

**Starting with Arrowhead 6.5.0:**

- Rootstock will behave same way as Ethereum's behavior for simulated transaction failures.
- If a simulated transaction step fails, the node will now return an error, mirroring Ethereum's response.

:::

You can see this behavior on the following example, where we call `eth_estimateGas` for a transaction that would be executed from an address without enough balance.

Expand Down

0 comments on commit f941284

Please sign in to comment.