[Cloud Security] add unit tests for createBenchmarkScoreIndex func (e…

…lastic#167121)

## Summary

a follow-up for elastic#166966 to add
unit tests

x-pack/plugins/cloud_security_posture/server/create_indices/create_indices.test.ts

@@ -0,0 +1,111 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+import { elasticsearchClientMock } from '@kbn/core-elasticsearch-client-server-mocks';
+import { loggingSystemMock } from '@kbn/core/server/mocks';
+import { createBenchmarkScoreIndex } from './create_indices';
+import {
+  BENCHMARK_SCORE_INDEX_DEFAULT_NS,
+  BENCHMARK_SCORE_INDEX_PATTERN,
+  BENCHMARK_SCORE_INDEX_TEMPLATE_NAME,
+  CSP_INGEST_TIMESTAMP_PIPELINE,
+} from '../../common/constants';
+import { IndicesGetIndexTemplateIndexTemplateItem } from '@elastic/elasticsearch/lib/api/types';
+
+const mockEsClient = elasticsearchClientMock.createClusterClient().asScoped().asInternalUser;
+
+describe('createBenchmarkScoreIndex', () => {
+  let logger: ReturnType<typeof loggingSystemMock.createLogger>;
+
+  beforeEach(() => {
+    logger = loggingSystemMock.createLogger();
+    jest.resetAllMocks();
+  });
+
+  it('should delete old index template from prev verions first', async () => {
+    mockEsClient.indices.getIndexTemplate.mockResolvedValueOnce({
+      index_templates: [{ name: 'foo' } as IndicesGetIndexTemplateIndexTemplateItem],
+    });
+    // @ts-ignore
+    await createBenchmarkScoreIndex(mockEsClient, { serverless: { enabled: false } }, logger);
+    expect(mockEsClient.indices.deleteIndexTemplate).toHaveBeenCalledTimes(1);
+    expect(mockEsClient.indices.deleteIndexTemplate).toHaveBeenCalledWith({
+      name: 'cloud_security_posture.scores',
+    });
+  });
+
+  it('should create index template with the correct index pattern, index name and default ingest pipeline', async () => {
+    // @ts-ignore
+    await createBenchmarkScoreIndex(mockEsClient, { serverless: { enabled: false } }, logger);
+    expect(mockEsClient.indices.putIndexTemplate).toHaveBeenCalledTimes(1);
+    expect(mockEsClient.indices.putIndexTemplate).toHaveBeenCalledWith(
+      expect.objectContaining({
+        name: BENCHMARK_SCORE_INDEX_TEMPLATE_NAME,
+        index_patterns: BENCHMARK_SCORE_INDEX_PATTERN,
+        template: expect.objectContaining({
+          settings: {
+            index: {
+              default_pipeline: CSP_INGEST_TIMESTAMP_PIPELINE,
+            },
+            lifecycle: {
+              name: '',
+            },
+          },
+        }),
+      })
+    );
+  });
+
+  it('should create index template the correct index patter, index name and default ingest pipeline but without lifecycle in serverless', async () => {
+    await createBenchmarkScoreIndex(
+      mockEsClient,
+      { serverless: { enabled: true }, enabled: true },
+      logger
+    );
+    expect(mockEsClient.indices.putIndexTemplate).toHaveBeenCalledTimes(1);
+    expect(mockEsClient.indices.putIndexTemplate).toHaveBeenCalledWith(
+      expect.objectContaining({
+        name: BENCHMARK_SCORE_INDEX_TEMPLATE_NAME,
+        index_patterns: BENCHMARK_SCORE_INDEX_PATTERN,
+        template: expect.objectContaining({
+          settings: expect.not.objectContaining({
+            lifecycle: {
+              name: '',
+            },
+          }),
+        }),
+      })
+    );
+  });
+
+  it('should create index if does not exist', async () => {
+    mockEsClient.indices.exists.mockResolvedValueOnce(false);
+
+    await createBenchmarkScoreIndex(
+      mockEsClient,
+      { serverless: { enabled: true }, enabled: true },
+      logger
+    );
+    expect(mockEsClient.indices.create).toHaveBeenCalledTimes(1);
+    expect(mockEsClient.indices.create).toHaveBeenCalledWith({
+      index: BENCHMARK_SCORE_INDEX_DEFAULT_NS,
+    });
+    expect(mockEsClient.indices.putMapping).toHaveBeenCalledTimes(0);
+  });
+
+  it('should updat index mapping if index exists', async () => {
+    mockEsClient.indices.exists.mockResolvedValueOnce(true);
+
+    await createBenchmarkScoreIndex(
+      mockEsClient,
+      { serverless: { enabled: true }, enabled: true },
+      logger
+    );
+    expect(mockEsClient.indices.create).toHaveBeenCalledTimes(0);
+    expect(mockEsClient.indices.putMapping).toHaveBeenCalledTimes(1);
+  });
+});

x-pack/plugins/cloud_security_posture/server/create_indices/create_indices.ts

@@ -65,7 +65,7 @@ export const initializeCspIndices = async (
   }
 };
 
-const createBenchmarkScoreIndex = async (
+export const createBenchmarkScoreIndex = async (
   esClient: ElasticsearchClient,
   cloudSecurityPostureConfig: CloudSecurityPostureConfig,
   logger: Logger