forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Security Solutions] Fix show top modal opened inside timeline shows …
…no result (elastic#168339) issue: elastic#168204 ## Summary Fix show top modal opened inside timeline shows no result. ### Summary: The TopN graph didn't take the timeline sorcerer scope into account. So it didn't display alert data. After elastic#165109 got merged, we started filtering the TopN graph by the timeline query. That made the current bug noticeable because we can filter by alert ID. The fix is to provide the `sourcererScopeId` to the graph. Screenshot after the change: <img width="889" alt="Screenshot 2023-10-09 at 13 04 42" src="https://github.com/elastic/kibana/assets/1490444/f41b941f-66f3-470b-b463-c0d45ab74d1f"> ### Extra * Delete unused prop `applyGlobalQueriesAndFilters` ### Checklist Delete any items that are not applicable to this PR. - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
- Loading branch information
Showing
3 changed files
with
11 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters