-
Notifications
You must be signed in to change notification settings - Fork 163
Conversation
Signed-off-by: Matthias Beyer <[email protected]>
Signed-off-by: Matthias Beyer <[email protected]>
Signed-off-by: Matthias Beyer <[email protected]>
Signed-off-by: Matthias Beyer <[email protected]>
Signed-off-by: Matthias Beyer <[email protected]>
Great you've been making progress, thanks also for Max (cannot tag from mobile ui) for helping out. I will be out of office until next week (xmas holidays) when I hope to fix the build and then merge this. Again, thanks for doing this! Note that I only suggested that you'd start the upgrade from first getting the |
Sure, no hurry!
Yes, sure! Upgrading bitswap was ... doable, but I fail to see why the root crate does not compile, so I figured I rather push this into a PR and we go from there instead me just becoming desperate 😆
No worries, I am a git ninja (>10 years experience, with different workflows and even email workflows etc etc)! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes itself look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good; compilation fails on your branch though, so the rest of the upgrade needs to be done on the ipfs side. If libp2p has already advanced to a next major version, then I'd suggest doing the ongoing upgrade first before moving on to the next.
Similar to #485, closing this as libp2p has been upgraded to 0.43. |
As suggsted in #485 I re-started my efforts starting with the
/bitswap
subtree for updating libp2p.Supersedes #485
Feel free to suggest how to continue! 😆