Skip to content
This repository has been archived by the owner on Oct 23, 2022. It is now read-only.

Draft: use Ed25519 instead of RSA by default, drop openssl dep #378

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ljedrz
Copy link
Member

@ljedrz ljedrz commented Sep 17, 2020

While I was looking at the upcoming go-ipfs 0.7 changes, the one that stood out to me most was the switch from RSA to Ed25519 keys by default; since the only reason why we're shipping openssl is that we be default generate RSA keys, this seemed to me like a good opportunity to ditch it and free ourselves from one of the trickiest dependencies.

Since I might have been a bit "heavy-handed" in the way I handled these changes and since they are quite severe, I'm posting it as a draft so that we can discuss this further, see how the CI changes fare etc. There's some work left wrt updating the README etc., but "the meat" is already here.

This would obviate #128.
Cc #170, #96

@ljedrz ljedrz requested a review from koivunej September 17, 2020 11:11
@ljedrz ljedrz changed the title Interop changes Draft: use Ed25519 instead of RSA by default, drop openssl dep Sep 17, 2020
@ljedrz
Copy link
Member Author

ljedrz commented Sep 17, 2020

Nice, the CI seems to agree with this approach; I'll just force-push the removal of libssl-dev I forgot to include initially.

@Logarithmus
Copy link

More than a year passed... Please merge this finally

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants