Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skipActivity on setConfig #815

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

troglotit
Copy link

@troglotit troglotit commented Jan 27, 2022

Hi!

This PR adds ability to fast-forward while replayer is already playing. Not sure that 100% is correct though

@YunFeng0817
Copy link
Member

Hi troglotit, I'm so sorry that I don't quite understand your newly added feature. Could you please provide a more detailed description of the application scenario?

@troglotit
Copy link
Author

I wanted to have an option to set skipInactive: true while the player is already playing and for it to start fast-forward, rather than to have to wait for next case EventType.IncrementalSnapshot event

@Juice10
Copy link
Contributor

Juice10 commented Mar 13, 2022

@troglotit could you add a test case which would fail (before you patch) and pass after this PR is applied?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants