Preserve iframe node id through loading callback

[eoghanmurray]

Ensure the iframe id survives the onceIframeLoaded process; for some reason I'm seeing the __sn attribute on the iframe DOM element disappearing with the callback

[Juice10]

LGTM!

[changeset-bot]

⚠️ No Changeset found

Latest commit: 9b4459e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[eoghanmurray]

So the circumstances of this PR were that the iframe element was 'somehow' losing it's __sn DOM attribute.

We no longer store the __sn in the DOM but rather retrieve the id from the mirror.

So now the question would be whether the identity of the iframe has changed such that in that scenario, the mirror wouldn't be able to retrieve it. I don't know as I don't have the scenario available anymore.

So we could merge as a precaution; what do you think @Juice10 ?

[Juice10]

@eoghanmurray we don't have a test case for this. And the underlying code has changed pretty heavily. I'm thinking we close this till it becomes a problem again and resurrect it then (with test case). But I'm not 100% on this one