-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow custom truncation suffix #1531
base: master
Are you sure you want to change the base?
feat: allow custom truncation suffix #1531
Conversation
🦋 Changeset detectedLatest commit: 8e52272 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@Juice10 noticed this while in there earlier... it's useful for us, but happy to drop it if not useful for the library generally :) |
packages/plugins/rrweb-plugin-console-record/test/stringify.test.ts
Outdated
Show resolved
Hide resolved
…st.ts Co-authored-by: Eoghan Murray <[email protected]>
@eoghanmurray ping on this for next week (i'm just watering my PRs while #4 daughter naps :)) |
when adding #1530 I realised that there's code in the console plugin for truncation that we're copying so our users have to download twice (not much but every little helps)
the only difference is we use (and some code expects) a different truncation marker
so, this