Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow custom truncation suffix #1531

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

pauldambra
Copy link
Contributor

when adding #1530 I realised that there's code in the console plugin for truncation that we're copying so our users have to download twice (not much but every little helps)

the only difference is we use (and some code expects) a different truncation marker

so, this

  • lets you add a custom truncation marker
  • and actively truncates strings not just objects that are being toString-ed

Copy link

changeset-bot bot commented Jul 2, 2024

🦋 Changeset detected

Latest commit: 8e52272

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@rrweb/rrweb-plugin-console-record Patch
rrweb Patch
rrweb-snapshot Patch
rrdom Patch
rrdom-nodejs Patch
rrweb-player Patch
@rrweb/all Patch
@rrweb/replay Patch
@rrweb/record Patch
@rrweb/types Patch
@rrweb/packer Patch
@rrweb/web-extension Patch
rrvideo Patch
@rrweb/rrweb-plugin-console-replay Patch
@rrweb/rrweb-plugin-sequential-id-record Patch
@rrweb/rrweb-plugin-sequential-id-replay Patch
@rrweb/rrweb-plugin-canvas-webrtc-record Patch
@rrweb/rrweb-plugin-canvas-webrtc-replay Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pauldambra
Copy link
Contributor Author

@Juice10 noticed this while in there earlier... it's useful for us, but happy to drop it if not useful for the library generally :)

@pauldambra
Copy link
Contributor Author

@eoghanmurray ping on this for next week (i'm just watering my PRs while #4 daughter naps :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants