-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support top-layer <dialog> recording & replay #1503
Conversation
🦋 Changeset detectedLatest commit: 9f2a27c The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
59de782
to
78849f3
Compare
e884282
to
dcc867c
Compare
…rweb into juice10/record-dialog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!! Thanks for taking this on :)
…10/record-dialog
rrdom downcases all attribute names which made `rr_openMode` tricky to deal with
a83c6e1
to
d693da9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing this. Overall, it looks good
rrdom already handles dialog element creation it's self
…rweb into juice10/record-dialog
Fixes #1381.
Adds support for recording & replaying Top Layer
<dialog>
elements. These elements float over any other elements no matter the z-index.What this PR does not do:
showModal()
on rrweb-snapshot'srebuild
.showModal()
has to be attached to be called, so the responsibility to do this is hoisted to rrweb & rrdom.popover
elements.requestFullScreen
elements.HTMLDialogElement.showModal
, and although that is possible I didn't have time to implement it. However most of the time this PR should sufficient. Unfortunately there is no way to query the dom for the order of elements in the top layer, as that would have made this doable without monkey patch, and recordable in rrweb-snapshot.