Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #1309 it looks like canvas mutations are not captured in certain environments. As was described in a comment on the change
From my investigations it looks like the worker in the
canvas-mutation
is not capturing messages in theonmessage
handler:rrweb/packages/rrweb/src/record/observers/canvas/canvas-manager.ts
Lines 122 to 226 in 729361e
I couldn't find any reason this stopped working but another bug (#1377) suggests that it is altering the outputted worker.
@mydea also discovered that the current worker setup might be causing issues with tree shaking and has adapted their fork to include a new
rrweb-worker
package. I went ahead and ported their solution over here as proposed in #1376.This removes the reliance on
rollup-plugin-web-worker-loader
which introduced the behaviour I'm seeing