[rrweb] Fix hookSetter maximum call stack exceeded #1313
Conversation
|
| @@ -104,15 +104,24 @@ export function hookSetter<T>( | |||
| isRevoked?: boolean, | |||
| win = window, | |||
| ): hookResetter { | |||
| const isAlreadyHooked = Object.prototype.hasOwnProperty.call( | |||
| target, | |||
| '__hooked__' + String(key), | |||
There was a problem hiding this comment.
we should have some indication on the DOM property to indicate it originates with rrweb
There was a problem hiding this comment.
We have window.__rrMutationObserver elsewhere, so maybe just __rrHooked would be good?
Fixes #731 by introducing the hooked property on the object.
This is needed to avoid recursive calls, which are currently happening at random inside the hook setter.
Also, instead of returning the hookSetter function in return, it will reset the original without creating more call stack entries.