Render full snapshot on scrub to zero #1140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ea0be35 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
eoghanmurray
force-pushed
the
renderFullSnapshotOnScrubToZero
branch
from
bddfd78 to
3064119
Compare
|
Tests are failing, maybe you could add a test for this use case if the current failing tests don't cover it. Apart from that this looks good and can be approved/merged |
…circle rather than a point during replay - We have to switch to 'onpointerdown' & 'onpointerup' in order to actually capture `e.pointerType` - this replaces 4 event listeners (MouseDown/MouseUp/TouchStart/TouchEnd) with 2 pointer ones which should fire in all 4 scenarios. We still output the old types according to the MouseInteractions enum - there is no Pointer equivalent of Click, so we leave that is, but use the last Pointer event to attach a pointerType to (only) the click event, where it is most useful - we can fallback to the old method for any browsers not supporting `window.PointerEvent`, in which case \`pointerType\` will be absent from all events
… ended up as a TouchEvent instead of an individual Touch object I think
…nterTypes.Mouse` is expected
… where a subsequent click would be picked up as a touch (see `thisEventKey` change)
… should be applied synchronously
- where this came up:
replayer.play(timestamp_of_a_snapshot)
replayer.pause()
Because of the immediate pause, the timer requestAnimationFrame never got to execute, and the snapshot wasn't rendered.
Of course this could also have been achieved with:
replayer.pause(timestamp_of_a_snapshot)
But I didn't know that
…der a FullSnapshot, similar to how the firstFullsnapshot logic works upon initilization of the player
|
Tests are failing as this PR makes things more complicated! |
eoghanmurray
force-pushed
the
renderFullSnapshotOnScrubToZero
branch
from
67ddf68 to
3cebc69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.