use Uppercase type

rrweb-io · Mar 6, 2023 · 023334b · 023334b
1 parent 4b89cee
commit 023334b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/packages/rrweb-snapshot/src/utils.ts b/packages/rrweb-snapshot/src/utils.ts
@@ -161,7 +161,7 @@ export function maskInputValue({
   maskInputFn,
 }: {
   maskInputOptions: MaskInputOptions;
-  tagName: 'SELECT' | 'INPUT' | 'TEXTAREA' | 'OPTION';
+  tagName: Uppercase<string>;
   type: string | number | boolean | null;
   value: string | null;
   maskInputFn?: MaskInputFn;

diff --git a/packages/rrweb/src/record/mutation.ts b/packages/rrweb/src/record/mutation.ts
@@ -483,14 +483,15 @@ export default class MutationBuffer {
         }
         break;
       }
+
       case 'attributes': {
         const target = m.target as HTMLElement;
         let value = (m.target as HTMLElement).getAttribute(m.attributeName!);
         if (m.attributeName === 'value') {
           value = maskInputValue({
             maskInputOptions: this.maskInputOptions,
-            tagName: (m.target as HTMLElement).tagName as 'SELECT' | 'INPUT' | 'TEXTAREA' | 'OPTION',
-            type: (m.target as HTMLElement).getAttribute('type'),
+            tagName: target.tagName as unknown as Uppercase<string>,
+            type: target.getAttribute('type'),
             value,
             maskInputFn: this.maskInputFn,
           });

diff --git a/packages/rrweb/src/record/observer.ts b/packages/rrweb/src/record/observer.ts
@@ -370,7 +370,7 @@ function initInputObserver({
     ) {
       text = maskInputValue({
         maskInputOptions,
-        tagName: (target as HTMLElement).tagName as 'SELECT' | 'INPUT' | 'TEXTAREA' | 'OPTION',
+        tagName: (target as HTMLElement).tagName as unknown as Uppercase<string>,
         type,
         value: text,
         maskInputFn,