-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for @layer CSS-rule #5
Conversation
🦋 Changeset detectedLatest commit: f9c312c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, some minor style suggestions (according to surrounding code).
Please note that i am not involved with this project and dont know the other code other than this PR, i also am not involved with css parsing in general.
Co-authored-by: hasezoey <[email protected]>
Co-authored-by: hasezoey <[email protected]>
Actually, seems like there was no code style policy at all even before I touched the code for the first time 😁 |
Fixing code styling problem would bring A LOT of changes among different files (even the files irrelevant to the issue). Maybe the repo needs some refactoring in general... |
What is the status of this PR? |
Any plans to get @layer support in? I can see this pr is open for a while, anything blocking to get it merged? |
@YunFeng0817 it's been some time without attention to this PR. |
Added support for
@layer
CSS-rule (CSS Layer Block)Gotta fix this issue and similar ones since
jsdom
utilizes this package.