Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for @layer CSS-rule #5

Merged
merged 6 commits into from
Oct 14, 2024
Merged

Conversation

simpleman383
Copy link

@simpleman383 simpleman383 commented Jun 5, 2024

Added support for @layer CSS-rule (CSS Layer Block)

Gotta fix this issue and similar ones since jsdom utilizes this package.

Copy link

changeset-bot bot commented Jun 5, 2024

🦋 Changeset detected

Latest commit: f9c312c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
rrweb-cssom Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@simpleman383 simpleman383 requested a review from hasezoey August 22, 2024 14:41
Copy link

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, some minor style suggestions (according to surrounding code).
Please note that i am not involved with this project and dont know the other code other than this PR, i also am not involved with css parsing in general.

lib/parse.js Outdated Show resolved Hide resolved
lib/parse.js Outdated Show resolved Hide resolved
simpleman383 and others added 2 commits August 22, 2024 18:13
Co-authored-by: hasezoey <[email protected]>
Co-authored-by: hasezoey <[email protected]>
@simpleman383
Copy link
Author

Actually, seems like there was no code style policy at all even before I touched the code for the first time 😁

@simpleman383
Copy link
Author

Fixing code styling problem would bring A LOT of changes among different files (even the files irrelevant to the issue). Maybe the repo needs some refactoring in general...

@smitev
Copy link

smitev commented Sep 6, 2024

What is the status of this PR?
@YunFeng0817 can we merge it?

@tijmenvangurp
Copy link

Any plans to get @layer support in? I can see this pr is open for a while, anything blocking to get it merged?

@smitev
Copy link

smitev commented Oct 14, 2024

@YunFeng0817 it's been some time without attention to this PR.
can we get your feedback on it?

@YunFeng0817 YunFeng0817 merged commit 9f7e335 into rrweb-io:master Oct 14, 2024
@github-actions github-actions bot mentioned this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Could not parse CSS stylesheet" when running tests with jest
5 participants