Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sqltoolsservice submodule #676

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Conversation

ErikEJ
Copy link
Collaborator

@ErikEJ ErikEJ commented Dec 29, 2024

fixes #675
parts of #674 (maybe all?)

@ErikEJ ErikEJ requested a review from jmezach December 30, 2024 07:29
@ErikEJ ErikEJ marked this pull request as ready for review December 30, 2024 07:30
@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Jan 10, 2025

@jmezach Are your concerns adressed?

Copy link
Member

@jmezach jmezach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, sorry. This LGTM :).

@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Jan 10, 2025

@jmezach I know it is not ideal, but at least slightly better than the current submodule trouble

@ErikEJ ErikEJ merged commit cffe858 into rr-wfm:master Jan 10, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Dependency on sqltoolsservice submodule
3 participants