Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .NET 9 RTW SDK #657

Merged
merged 1 commit into from
Nov 13, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -31,7 +31,6 @@ jobs:
uses: actions/setup-dotnet@v4
with:
dotnet-version: '9.0.x'
dotnet-quality: 'preview'

- name: Setup dotnet 8.0
uses: actions/setup-dotnet@v4

Unchanged files with check annotations Beta

using System;
namespace MSBuild.Sdk.SqlProj.DacpacTool

Check warning on line 3 in src/DacpacTool/ActualConsole.cs

GitHub Actions / build

Namespace "MSBuild.Sdk.SqlProj.DacpacTool" does not match folder structure, expected "DacpacTool" (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0130)
{
public class ActualConsole : IConsole
{
namespace MSBuild.Sdk.SqlProj.DacpacTool

Check warning on line 1 in src/DacpacTool/BaseOptions.cs

GitHub Actions / build

Namespace "MSBuild.Sdk.SqlProj.DacpacTool" does not match folder structure, expected "DacpacTool" (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0130)
{
public abstract class BaseOptions
{
using System.IO;
using Microsoft.SqlServer.Dac.Model;
namespace MSBuild.Sdk.SqlProj.DacpacTool

Check warning on line 4 in src/DacpacTool/BuildOptions.cs

GitHub Actions / build

Namespace "MSBuild.Sdk.SqlProj.DacpacTool" does not match folder structure, expected "DacpacTool" (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0130)
{
[System.Diagnostics.CodeAnalysis.SuppressMessage("Performance", "CA1819:Properties should not return arrays", Justification = "Used a DTO")]
public class BuildOptions : BaseOptions
using System;
namespace MSBuild.Sdk.SqlProj.DacpacTool

Check warning on line 3 in src/DacpacTool/DatabaseProperty.cs

GitHub Actions / build

Namespace "MSBuild.Sdk.SqlProj.DacpacTool" does not match folder structure, expected "DacpacTool" (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0130)
{
internal sealed class DatabaseProperty
{
using System.IO;
namespace MSBuild.Sdk.SqlProj.DacpacTool

Check warning on line 3 in src/DacpacTool/DeployOptions.cs

GitHub Actions / build

Namespace "MSBuild.Sdk.SqlProj.DacpacTool" does not match folder structure, expected "DacpacTool" (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0130)
{
#pragma warning disable CA1812 // Avoid uninstantiated internal classes
internal sealed class DeployOptions : BaseOptions
using System.Text;
using Microsoft.SqlServer.Dac.Extensibility;
namespace MSBuild.Sdk.SqlProj.DacpacTool

Check warning on line 5 in src/DacpacTool/ExtensibilityErrorExtensions.cs

GitHub Actions / build

Namespace "MSBuild.Sdk.SqlProj.DacpacTool" does not match folder structure, expected "DacpacTool" (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0130)
{
/// <summary>
/// A wrapper for <see cref="ExtensibilityError" /> that provides MSBuild compatible output and source document information.
using Microsoft.SqlServer.TransactSql.ScriptDom;
using Microsoft.SqlTools.ServiceLayer.BatchParser.ExecutionEngineCode;
namespace MSBuild.Sdk.SqlProj.DacpacTool

Check warning on line 13 in src/DacpacTool/Extensions.cs

GitHub Actions / build

Namespace "MSBuild.Sdk.SqlProj.DacpacTool" does not match folder structure, expected "DacpacTool" (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0130)
{
#pragma warning disable CA1724 // Type names should not match namespaces
public static class Extensions
namespace MSBuild.Sdk.SqlProj.DacpacTool

Check warning on line 1 in src/DacpacTool/IConsole.cs

GitHub Actions / build

Namespace "MSBuild.Sdk.SqlProj.DacpacTool" does not match folder structure, expected "DacpacTool" (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0130)
{
public interface IConsole
{
using Microsoft.SqlTools.ServiceLayer.BatchParser;
using Microsoft.SqlTools.ServiceLayer.BatchParser.ExecutionEngineCode;
namespace MSBuild.Sdk.SqlProj.DacpacTool

Check warning on line 6 in src/DacpacTool/IncludeVariableResolver.cs

GitHub Actions / build

Namespace "MSBuild.Sdk.SqlProj.DacpacTool" does not match folder structure, expected "DacpacTool" (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0130)
{
// This was just copied from Microsoft.SqlTools.ManagedBatchParser.UnitTests.BatchParser.TestVariableResolver
// No special functionality needed for our project
using System.IO;
namespace MSBuild.Sdk.SqlProj.DacpacTool

Check warning on line 3 in src/DacpacTool/InspectOptions.cs

GitHub Actions / build

Namespace "MSBuild.Sdk.SqlProj.DacpacTool" does not match folder structure, expected "DacpacTool" (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0130)
{
public class InspectOptions : BaseOptions
{