Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sqltoolsservice #652

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jmezach
Copy link
Member

@jmezach jmezach commented Oct 30, 2024

This updates the sqltoolsservice submodule to the latest version. I don't think we can easily get rid of this dependency, but at least now it is up-to-date again against the latest commit there. Hopefully this will pass CI as well.

Signed-off-by: Jonathan Mezach [email protected]

Signed-off-by: Jonathan Mezach <[email protected]>
@jmezach
Copy link
Member Author

jmezach commented Oct 30, 2024

Interestingly CI is failing, but running the exact same command on my devbox works just fine

@ErikEJ
Copy link
Collaborator

ErikEJ commented Oct 30, 2024

Have you done a hard clean of your repo?

@jmezach
Copy link
Member Author

jmezach commented Oct 31, 2024

I tried and it did produce errors. Unfortunately it is a bit hard to find the errors since we're also getting about 1200 warnings from this code. We have it marked as generated code in our .editorconfig, but this is not being picked up since the sqltoolsservice repo also has a .editorconfig with root = true.

@ErikEJ
Copy link
Collaborator

ErikEJ commented Nov 17, 2024

2024-10-30T15:10:40.6862789Z /usr/share/dotnet/sdk/9.0.100-rc.2.24474.11/Microsoft.Common.CurrentVersion.targets(5035,5): error MSB3021: Unable to copy file "/home/runner/work/MSBuild.Sdk.SqlProj/MSBuild.Sdk.SqlProj/sqltoolsservice/src/Microsoft.SqlTools.Hosting/bin/Release/net8.0/zh-hant/Microsoft.SqlTools.Hosting.resources.dll" to "bin/Release/net8.0/zh-hant/Microsoft.SqlTools.Hosting.resources.dll". Could not find a part of the path '/home/runner/work/MSBuild.Sdk.SqlProj/MSBuild.Sdk.SqlProj/src/DacpacTool/bin/Release/net8.0/zh-hant/Microsoft.SqlTools.Hosting.resources.dll'. [/home/runner/work/MSBuild.Sdk.SqlProj/MSBuild.Sdk.SqlProj/src/DacpacTool/DacpacTool.csproj::TargetFramework=net8.0]

@ErikEJ
Copy link
Collaborator

ErikEJ commented Nov 26, 2024

@jmezach ^^

@jmezach
Copy link
Member Author

jmezach commented Nov 26, 2024

Yeah, still haven't been able to figure out why CI is failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants