Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a version check and warn if not using latest #632

Merged
merged 9 commits into from
Oct 11, 2024
Merged

Add a version check and warn if not using latest #632

merged 9 commits into from
Oct 11, 2024

Conversation

ErikEJ
Copy link
Collaborator

@ErikEJ ErikEJ commented Oct 3, 2024

fixes #629

@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Oct 3, 2024

image

jmezach
jmezach reviewed Oct 3, 2024
View reviewed changes
src/DacpacTool/Program.cs Outdated Show resolved Hide resolved
jmezach
jmezach reviewed Oct 3, 2024
View reviewed changes
src/DacpacTool/Program.cs Outdated Show resolved Hide resolved
jmezach
jmezach reviewed Oct 3, 2024
View reviewed changes
Copy link
Member

@jmezach jmezach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is off to a great start, just some considerations that I think we should think about

@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Oct 7, 2024

@jmezach Thoughts after the updated approach?

jmezach
jmezach reviewed Oct 8, 2024
View reviewed changes
src/DacpacTool/Program.cs Outdated Show resolved Hide resolved
jmezach
jmezach approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@jmezach jmezach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small comments

@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Oct 10, 2024

@jmezach Updated

@jmezach
Copy link
Member

jmezach commented Oct 10, 2024

Looking good now. Perhaps @jeffrosenberg can have a look as well and then we can merge this.

jeffrosenberg
jeffrosenberg approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@jeffrosenberg jeffrosenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a heads-up, I'm in between two vacations at the moment. I'm going to look through all outstanding PRs, but then won't be available for a week. Feel free to merge PRs without my review during that time if you'd like!

@ErikEJ ErikEJ merged commit 2b52b3d into rr-wfm:master Oct 11, 2024
10 checks passed
@ErikEJ
Copy link
Collaborator Author

ErikEJ commented Oct 11, 2024

@jmezach Should we push a 2.9.2 release - or maybe just wait for 3.0 (preview) ?

@jmezach
Copy link
Member

jmezach commented Oct 11, 2024

I think this can wait for 3.0

@ErikEJ ErikEJ mentioned this pull request Oct 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmezach jmezach jmezach approved these changes

@jeffrosenberg jeffrosenberg jeffrosenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate a way for the SDK to test for latest version
3 participants
@ErikEJ @jmezach @jeffrosenberg