Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive plots #161

Merged
merged 10 commits into from
Dec 13, 2024
Merged

Interactive plots #161

merged 10 commits into from
Dec 13, 2024

Conversation

mjmroz
Copy link
Contributor

@mjmroz mjmroz commented Dec 8, 2024

bug fixed

@rpoleski
Copy link
Owner

rpoleski commented Dec 8, 2024

Please change version to 0.41.1.

mjmroz and others added 3 commits December 9, 2024 06:28
@rpoleski
Copy link
Owner

rpoleski commented Dec 9, 2024

  1. _mark_second_Y_axis_in_best_plot() and _get_interactive_second_Y_axis_settings_() have some common lines. We try to reduce copy-pasting of the code in order to make future development easier. Please try to define a new function that does the common part of the above two functions.
  2. I like the extension. To follow semantic versioning, please increase minor version, i.e., to 0.42.0.

@rpoleski
Copy link
Owner

Out of my curiosity:

time_grid = int(t_stop-t_start)*7

where 7 comes from? Or why 7 is used here?

@rpoleski
Copy link
Owner

Thanks!

@rpoleski rpoleski merged commit b8a6085 into rpoleski:master Dec 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants