Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interp2d import, issue #74 #113

Merged
merged 7 commits into from
Dec 21, 2023

Conversation

rapoliveira
Copy link
Contributor

@rapoliveira rapoliveira commented Dec 4, 2023

The scipy function interp2d (to be deprecated soon, issue #74) was replaced by RegularGridInterpolator in two codes:

  • souce/pointlens.py
  • data/interpolate_elliptic_integral_3.py

I tested the changes only in the second code, which lead to differences smaller than 1e-10 in the interpolated values.

@rapoliveira
Copy link
Contributor Author

@rpoleski the tests failed in test_Lee09_and_WittMao94() function of test_MagnificationCurve.py, but passed in my local repository. Since the failure is not related to my changes, should I try to commit once more?

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2e55c55) 83.61% compared to head (8e879bb) 83.53%.
Report is 4 commits behind head on master.

Files Patch % Lines
source/MulensModel/pointlens.py 66.66% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
- Coverage   83.61%   83.53%   -0.08%     
==========================================
  Files          52       52              
  Lines        8271     8286      +15     
==========================================
+ Hits         6916     6922       +6     
- Misses       1355     1364       +9     
Flag Coverage Δ
unittests 83.53% <66.66%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rpoleski rpoleski merged commit 03de1a6 into rpoleski:master Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants