Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opensuse] SUIDPermissionsCheck: support new /usr/share/permissions/packages.d dir #1190

Merged

Conversation

mgerstner
Copy link
Contributor

  • use common constant to refer to /usr/share/permissions
  • adjust comments to current situation
  • consider the new packages.d directory as well (new chkstat from permissions package supports this).

Due to the generator used in _paths_to() this is getting a bit ugly to combine now. We should only consider packages.d in the /usr dir, not in /etc, where the name is too generic.

Copy link

@FilippoBonazziSUSE FilippoBonazziSUSE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comments above, the rest looks ok

rpmlint/checks/SUIDPermissionsCheck.py Outdated Show resolved Hide resolved
- use common constant to refer to /usr/share/permissions
- adjust comments to current situation
- consider the new packages.d directory as well (new chkstat from
  permissions package supports this).
@mgerstner
Copy link
Contributor Author

Now the tumbleweed rpm-build fails. But I don't see this related to my change.

@danigm
Copy link
Member

danigm commented Feb 13, 2024

Now the tumbleweed rpm-build fails. But I don't see this related to my change.

The failing CI is not related to this change: #981 (comment)

Copy link

@FilippoBonazziSUSE FilippoBonazziSUSE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cleaner now

@FilippoBonazziSUSE FilippoBonazziSUSE merged commit 6dbb648 into rpm-software-management:opensuse Feb 13, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants