Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polkit-rules-whitelist: add fudo rules (bsc#1215948) #1116

Merged

Conversation

mgerstner
Copy link
Contributor

@FilippoBonazziSUSE
Copy link

Broken, seems to be missing a [[FileDigestGroup]] header for the very first fudo entry.

Copy link

@FilippoBonazziSUSE FilippoBonazziSUSE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're not specifying the digester field for any of the hashes, I assume there is a sane default?

Other than that LGTM.

@mgerstner
Copy link
Contributor Author

You're not specifying the digester field for any of the hashes, I assume there is a sane default?

Yes the default is to hash the unmodified file contents. Since these Polkit rules are Java script we don't have a matching filter yet and the default suffices.

@FilippoBonazziSUSE
Copy link

I think the mageia-cauldron CI failures are unrelated. Merging

@FilippoBonazziSUSE FilippoBonazziSUSE merged commit fea5c44 into rpm-software-management:opensuse Oct 6, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants