test: Add tests to check non-standard-dir-perm

See #1196

rpmlint/pkg.py

@@ -843,6 +843,9 @@ def _mock_file(self, path, attrs):
                 self.add_dir(str(i))
         metadata = attrs.get('metadata', None)
 
+        if attrs.get('is_dir', False):
+            self.add_dir(path, metadata=metadata)
+
         content = ''
         if 'content-path' in attrs:
             content = open(attrs['content-path'], 'rb')
@@ -873,11 +876,16 @@ def create_files(self, files):
             for path, file in files.items():
                 self._mock_file(path, file)
 
-    def add_dir(self, path):
+    def add_dir(self, path, metadata=None):
         pkgdir = PkgFile(path)
         pkgdir.magic = 'directory'
         pkgdir.path = path
         self.files[path] = pkgdir
+
+        if metadata:
+            for k, v in metadata.items():
+                setattr(pkgdir, k, v)
+
         return pkgdir
 
     def add_file_with_content(self, name, content, metadata=None, **flags):

test/test_files.py

@@ -300,3 +300,36 @@ def test_shebang_ok(package, output, test):
     test.check(package)
     out = output.print_results(output.results)
     assert 'W: symlink-to-binary-with-shebang /usr/bin/testlink' not in out
+
+
+@pytest.mark.parametrize('package', [
+    get_tested_mock_package(
+        header={'requires': []},
+        files={
+            '/etc/raddb/mods-config/sql/moonshot-targeted-ids/mysql': {
+                'is_dir': True,
+                'metadata': {'mode': 0o640 | stat.S_IFDIR},
+            },
+            '/etc/raddb/mods-config/sql/moonshot-targeted-ids/postgresql': {
+                'is_dir': True,
+                'metadata': {'mode': 0o640 | stat.S_IFDIR},
+            },
+            '/etc/raddb/mods-config/sql/moonshot-targeted-ids/sqlite': {
+                'is_dir': True,
+                'metadata': {'mode': 0o640 | stat.S_IFDIR},
+            },
+        },
+    ),
+])
+def test_directory_without_x_permission(package, output, test):
+    test.check(package)
+    out = output.print_results(output.results)
+    assert 'E: non-standard-dir-perm' in out
+
+
+@pytest.mark.parametrize('package', ['binary/freeradius-server'])
+def test_directory_without_x_permission2(tmp_path, package, filescheck):
+    output, test = filescheck
+    test.check(get_tested_package(package, tmp_path))
+    out = output.print_results(output.results)
+    assert 'E: non-standard-dir-perm' in out