Make the signing macros parametric #3476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Eh, completely forgot we do now have a C++ variant for rpmExpandThisMacro() too 🤦 😆 |
|
Looks good to me. Can you please rebase and then merge? |
|
FWIW, the first patch in this series inspired me to whip up #3477, so actually I'd prefer to get that merged first and then rebase this on top. |
|
Reviewed and merged #3477. |
These have been in this bizarre double-command format for passing to execve(), but there's really no point. Just make it a regular command and pass the same argument as the pathname and argv[0]. No functional changes.
It's not any less code, but gives us much better control over how they're called, eliminating the need for global temporary macros for passing what really are command arguments. No functional change, but paves way for future programmatic switches such as perhaps binary/ascii signatures. This is of course incompatible with folks who have their own custom %__gpg_sign_cmd from the past, recipes for these have unfortunately commonly floated around the internet as "necessary" for signing. These are double-underscore macros, people messing with those had better know what they're doing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not any less code, but gives us much better control over how they're called, eliminating the need for global temporary macros for passing what really are command arguments.
No functional change, but paves way for future programmatic switches such as perhaps binary/ascii signatures.
This is of course incompatible with folks who have their own custom %__gpg_sign_cmd from the past, recipes for these have unfortunately commonly floated around the internet as "necessary" for signing. These are double-underscore macros, people messing with those had better know what they're doing.