Exempt src.rpm packages from file signature business #3470
+82
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmnks
changed the title
pmatilai
reviewed
Nov 26, 2024
pmatilai
reviewed
Nov 26, 2024
|
Should be fixed now, based on the above discussion. Note that I'm not a huge fan of the additional |
|
Argh, what a strange CI failure, looking now... |
|
A silly memory leak in my code! Fixing now... |
|
... aaand fixed. |
This shouldn't normally happen but rpmtsPlugins() does return NULL when the passed transaction (ts) is NULL. Handle that in the plugin hooks and other utility functions so that we don't try to dereference a NULL pointer in such a case. This is also useful for the next commit where we'll make this into a deliberate case.
Source packages aren't really "installed", just unpacked, and plugins are by design meant for transactions, so disable the tsm/fsm/psm and scriptlet hooks for those. Note that the init and cleanup hooks will still run, those are supposed to only do reversible actions such as opening and closing files, and we wouldn't avoid them if there was a binary package supplied on the rpm -i command line anyway. This fixes, in particular, src.rpm installations done by a regular user (a common case) on systems with a plugin that requires root privileges, such as the ima plugin, which would otherwise cause a spurious warning or even failure (see RhBug:2316785). Extending rpmtsPlugins() here would be nicer but it's public API so just add a static wrapper. Reuse the plugin development test, we don't have anything better at the moment and it does the job well.
File signatures make no sense in source packages as they don't ship binaries to be installed on the target system, they're just fancy archives unpacked into %_topdir for packaging purposes. Disable the respective flags when processing a src.rpm and log a debug message as a heads-up, but don't skip the rest, header signatures are still relevant for source rpms, as is the deletion of existing file signatures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't add file signatures to source packages and if they happen to be present (i.e. built with an older rpm version), ignore them when unpacking (by not running plugins at all for source packages).
AC (taken from original bug):