Run test-suite with plugins enabled now that we can #2639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilable Same as commit 708e613, this message will just annoy and confuse users in situations where DBus service is not running at all, such as single-user mode and minimal container type environments. Like our own test-suite. Rather than entirely suppress the error, issue a debug log though.
Make systemd_inhibit plugin behave identically to dbus_announce in the previous commit: when DBus service isn't available, emit a debug level message rather than completely suppressing the message to keep things troubleshootable.
pmatilai
force-pushed
the
testplugins-pr
branch
from
db4bc86
to
047d4ee
Compare
|
LGTM! Of course, not all of the plugins will work in a container setup but as long as it's handled gracefully in RPM (which the other two commits do), there's no reason to disable them any more. Nice! |
|
Yup, I expect we need to (be able to) selectively disable some plugins at times, and we'll need some better mechanisms for doing so than we have now, but we'll cross that bridge when we come to it 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the fancy new container-based test-suite, we can actually enable plugins in the test-suite 🥳
The first commit is required for doing this, the second is merely for consistency.