Don't drop cached packages when only removing packages (RhBug:2237883) #885
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have a easier workflow for making package caching exceptions for some commands and also to match the
keepcache
behavior with the original dnf in this matter, the cached files are now removed only whenkeepcache
option is turned off at the moment.We don't want to remove the stored packages cache after running the
remove
command transaction, therefore we override thekeepcache
option to true. This is useful for use cases when the previous transaction downloaded a large amount of data, but didn't finished correctly. Then we'd like to fix the system state by removing some problematic package. We don't want to lose our cached data in this case.CI tests: rpm-software-management/ci-dnf-stack#1381
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2237883