Limit exclude search for only NEVRA #788
Conversation
The issue was created by adding binary search that is enabled by default. Closes: rpm-software-management#763
|
I might be worth clarifying in |
| .with_nevra = true, | ||
| .with_provides = false, | ||
| .with_filenames = false, | ||
| .with_binaries = false}; |
There was a problem hiding this comment.
Looking at the number of occurrences of ResolveSpecSettings usages, it almost seems that it would be better to use with_binaries = false as the default value for this struct.
There was a problem hiding this comment.
There are also multiple places where also GoalJobSettings (which is a subclass of ResolveSpecSettings) is used. And on top of that, almost every Goal class method accepts GoalJobSettings argument with default value const libdnf5::GoalJobSettings & settings = libdnf5::GoalJobSettings().
I guess all calls of these methods need to be checked after change of default value of with_binaries.
|
There still are places where Line 596 in 43eb2cd I'm just guessing that you were searching for ResolveSpecSettings to find all affected places. Maybe you should search for with_filenames instead to cover additional occurrences.
|
It prevents similar to exclude packages according to binary name.
|
I found additional occurrence. Thank you for suggestions. |
|
There is a file |
Hm, support for the |
Oh, I didn't notice that you've added the implementation :) |
|
Fixed |
9c3d4ea
The issue was created by adding binary search that is enabled by default.
Closes: #763
CI-Test: rpm-software-management/ci-dnf-stack#1353