rpm::Transaction: Enable installonly pkg downgrade #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To correctly filter out the "package kernel-x (which is newer than kernel-y) is already installed" RPM transaction problem, we need to determine whether a downgrade operation is present in the transaction. The current implementation relies on the presence of a "downgrade" operation in the solver results. However, for install-only packages, there is no "downgrade" operation; only an "install" operation. This patch introduces detection to identify if an install-only package of an older version is present in the transaction. It then sets ignored problems in the RPM transaction accordingly. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2221308 Resolves: #720
kontura
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To correctly filter out the
"package kernel-x (which is newer than kernel-y) is already installed"
RPM transaction problem, we need to determine whether a downgrade
operation is present in the transaction.
The current implementation relies on the presence of a "downgrade"
operation in the solver results. However, for install-only packages,
there is no "downgrade" operation; only an "install" operation.
This patch introduces detection to identify if an install-only package
of an older version is present in the transaction. It then sets ignored
problems in the RPM transaction accordingly.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2221308
Resolves: #720
Tests: rpm-software-management/ci-dnf-stack#1337