Advisory command for dnfdaemon #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-blaha
force-pushed
the
mblaha/daemon-updateinfo
branch
from
7397fe7
to
de017f0
Compare
|
This will be needed to enable moving dnfdragora from the old dnfdaemon to this one. |
m-blaha
force-pushed
the
mblaha/daemon-updateinfo
branch
3 times, most recently
from
3d51882
to
435640d
Compare
m-blaha
force-pushed
the
mblaha/daemon-updateinfo
branch
from
435640d
to
04320d8
Compare
kontura
reviewed
Aug 9, 2023
Comment on lines
+110
to
+111
| collection["packages"] = std::move(packages); | ||
| collection["modules"] = std::move(modules); |
There was a problem hiding this comment.
Just a note: Clang is warning here that: Passing result of std::move() as a const reference argument; no move will actually happen.
If I understand correctly this is because it is assigning to sdbus::Variant and it doesn't have a move constructor.
Thought I don't think its causing any problems.
There was a problem hiding this comment.
Hm, I cannot see the warning (I'm on F38).
There was a problem hiding this comment.
Sorry, its from clang-tidy not a regular clang compile.
The patch unifies dnf5daemon-client behavior with dnf5.
Thiw way the same output function can by used by both dnf5 and dnf5daemon-client.
Provides method to get a list of update advisories.
The change enables "dnf5daemon-client advisory info" to use the same code as "dnf5 advisory info" for printing outputs.
m-blaha
force-pushed
the
mblaha/daemon-updateinfo
branch
from
63c0005
to
9cb00c1
Compare
kontura
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Advisory interface for dnf5daemon-server. Also
dnf5daemon-client advisory listanddnf5daemon-client advisory infocommands were implemented.Tests: rpm-software-management/ci-dnf-stack#1356
Resolves: #451
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2184329