Add --json output to advisory info #1970
Open
+118
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stewartsmith
force-pushed
the
advisory-info-json
branch
from
f9d6c5d to
fce16cc
Compare
Enable --json for 'dnf advisory info'. The same information as would be displayed as text is included in the JSON output. While the libscols code could be adapted to produce JSON as well, without serious reworking of key_value_table (and all callers), the produced JSON is quite weird, so we instead choose to implement the JSON output separately.
stewartsmith
force-pushed
the
advisory-info-json
branch
from
fce16cc to
b8d84f5
Compare
kontura
reviewed
Jan 2, 2025
Comment on lines
+135
to
+136
| json_object_array_add(json_modules, json_object_new_string((*module_iter)->get_nsvca().c_str())); | ||
| module_iter++; |
There was a problem hiding this comment.
This is a little bit confusing, I think we don't have to do the first iteration outside of the loop here.
Unlike the regular version the first json line is formatted the same way as the rest.
Comment on lines
+149
to
+150
| json_object_array_add(json_pkgs, json_object_new_string((*package_iter)->get_nevra().c_str())); | ||
| package_iter++; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable --json for 'dnf advisory info'. The same information as would be displayed as text is included in the JSON output. While the libscols code could be adapted to produce JSON as well, without serious reworking of key_value_table (and all callers), the produced JSON is quite weird, so we instead choose to implement the JSON output separately.
Example output from
dnf5 advisory info --json FEDORA-2024-1ec4cd5fd3: