When writing main solv file (primary.xml) don't store filelists #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a repo filelists are stored in different repodata, limit the written repodata when writing main solv file. Otherwise the filelists are stored twice: in the main solv file and in the filelists specific solvx file. (This happens when downloading both the primary.xml and filelists.xml at the same time.) It also improves performance because when filelists were part of main solv file they were always loaded (regardless of the `optional_metadata_types` option).
m-blaha
approved these changes
Oct 3, 2024
Merged
via the queue into
rpm-software-management:main
with commit Oct 3, 2024
b2a5461
17 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a repo filelists are stored in different
repodata, limit the writtenrepodatawhen writing main solv file.Otherwise the filelists are stored twice: in the main solv file and in the filelists specific solvx file. (This happens when downloading both the primary.xml and filelists.xml at the same time.)
It also improves performance because when filelists were part of main solv file they were always loaded (regardless of the
optional_metadata_typesoption).Closes: #1749